[MCC-1498582] - Create layered design - #17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the new layered client/service/transport design by adjusting the public usage example and refining error handling/translation across the transport and service layers.
Changes:
- Updates the README quick-start to use
DataConnectClient.get_studies(...). - Changes Arrow Flight transport behavior for unsupported actions to raise a status-based transport error.
- Adds a defensive check in the service mapper when converting
ResourceInfotoStudy, and expands service parsing exception handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Updates quick-start usage of the client API. |
| dataconnect/transport/arrow_flight/transport.py | Adjusts the error type raised for unknown/unsupported actions. |
| dataconnect/service/mappers.py | Adds validation around missing endpoints/tickets when mapping resources to domain models. |
| dataconnect/service/default.py | Expands response-format exception handling when mapping studies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ibaig-mdsol
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MCC-1498582] - Create layered design
Changes